I’m doing my own playthrough of my big game. I’m carrying 29 objects and my game is getting slower between rooms, maybe .5 to 1.0 seconds of delay. Dropping all items shortens the delay.
I have numerous rules firing; I’m pretty sure it’s not a scope issue, as RULES doesn’t show any scope loop, and the same rules are firing when objects are carried as when objects are not.
Is there a way to print a real-time timestamp for each rule to figure out how long each rule is running? Or is there another effective way to determine which part of the code is slowing things down?
It may just be having a lot of small rules that cause the problem. Here’s a sample turn when carrying many items:
Summary
[Rule "After reading a command" applies.]
[Rule "After reading a command" applies.]
[Rule "declare everything initially unmentioned rule" applies.]
[Rule "standard set going variables rule" applies.]
[Rule "announce items from multiple object lists rule" applies.]
[Rule "set pronouns from items from multiple object lists rule" applies.]
[Rule "before stage rule" applies.]
[Rule "instead stage rule" applies.]
[Rule "Instead of going somewhere when the player encloses something ( called the stolen goods ) which is not owned by the player" applies.]
[Rule "investigate player's awareness before action rule" applies.]
[Rule "player aware of his own actions rule" applies.]
[Rule "check stage rule" applies.]
[Rule "can't travel in what's not a vehicle rule" applies.]
[Rule "can't go through undescribed doors rule" applies.]
[Rule "can't go through closed doors rule" applies.]
[Rule "determine map connection rule" applies.]
[Rule "can't go that way rule" applies.]
[Rule "can't go through closed rifts rule" applies.]
[Rule "can't go through closed ladders rule" applies.]
[Rule "carry out stage rule" applies.]
[Rule "move player and vehicle rule" applies.]
[Rule "move floating objects rule" applies.]
[Rule "check light in new location rule" applies.]
[Rule "after stage rule" applies.]
[Rule "investigate player's awareness after action rule" applies.]
[Rule "report stage rule" applies.]
[Rule "describe room gone into rule" applies.]
[Rule "determine visibility ceiling rule" applies.]
[Rule "investigate player's awareness before action rule" applies.]
[Rule "player aware of his own actions rule" applies.]
[Rule "check stage rule" applies.]
[Rule "carry out stage rule" applies.]
[Rule "declare everything unmentioned rule" applies.]
[Rule "room description heading rule" applies.]
Cabin
[Rule "room description body text rule" applies.]
The interior is modest, with a table and a couple of chairs, and little else in terms of decoration. There is a fireplace along one wall with a copper apparatus built over it. You can hear the rain falling on the cabin.
On the table is a cold press.
A red door leads back to the north, while a blue door leads to the south. Stairs lead up to another floor, but they look dangerously damaged.
[Rule "room description paragraphs about objects rule" applies.]
[Rule "initialise locale description rule" applies.]
[Rule "find notable locale objects rule" applies.]
[Rule "standard notable locale objects rule" applies.]
[Rule "interesting locale paragraphs rule" applies.]
[Rule "don't mention player's supporter in room descriptions rule" applies.]
[Rule "don't mention scenery in room descriptions rule" applies.]
[Rule "don't mention undescribed items in room descriptions rule" applies.]
[Rule "set pronouns from items in room descriptions rule" applies.]
[Rule "offer items to writing a paragraph about rule" applies.]
[Rule "use initial appearance in room descriptions rule" applies.]
[Rule "describe what's on scenery supporters in room descriptions rule" applies.]
[Rule "describe what's on mentioned supporters in room descriptions rule" applies.]
[Rule "don't mention player's supporter in room descriptions rule" applies.]
[Rule "don't mention scenery in room descriptions rule" applies.]
[Rule "don't mention undescribed items in room descriptions rule" applies.]
[Rule "set pronouns from items in room descriptions rule" applies.]
[Rule "offer items to writing a paragraph about rule" applies.]
[Rule "use initial appearance in room descriptions rule" applies.]
[Rule "describe what's on scenery supporters in room descriptions rule" applies.]
[Rule "describe what's on mentioned supporters in room descriptions rule" applies.]
[Rule "don't mention player's supporter in room descriptions rule" applies.]
[Rule "don't mention scenery in room descriptions rule" applies.]
[Rule "don't mention undescribed items in room descriptions rule" applies.]
[Rule "set pronouns from items in room descriptions rule" applies.]
[Rule "offer items to writing a paragraph about rule" applies.]
[Rule "use initial appearance in room descriptions rule" applies.]
[Rule "describe what's on scenery supporters in room descriptions rule" applies.]
[Rule "describe what's on mentioned supporters in room descriptions rule" applies.]
[Rule "don't mention player's supporter in room descriptions rule" applies.]
[Rule "don't mention scenery in room descriptions rule" applies.]
[Rule "don't mention undescribed items in room descriptions rule" applies.]
[Rule "set pronouns from items in room descriptions rule" applies.]
[Rule "offer items to writing a paragraph about rule" applies.]
[Rule "use initial appearance in room descriptions rule" applies.]
[Rule "describe what's on scenery supporters in room descriptions rule" applies.]
[Rule "describe what's on mentioned supporters in room descriptions rule" applies.]
[Rule "don't mention player's supporter in room descriptions rule" applies.]
[Rule "don't mention scenery in room descriptions rule" applies.]
[Rule "don't mention undescribed items in room descriptions rule" applies.]
[Rule "set pronouns from items in room descriptions rule" applies.]
[Rule "offer items to writing a paragraph about rule" applies.]
[Rule "use initial appearance in room descriptions rule" applies.]
[Rule "describe what's on scenery supporters in room descriptions rule" applies.]
[Rule "describe what's on mentioned supporters in room descriptions rule" applies.]
[Rule "don't mention player's supporter in room descriptions rule" applies.]
[Rule "don't mention scenery in room descriptions rule" applies.]
[Rule "don't mention undescribed items in room descriptions rule" applies.]
[Rule "set pronouns from items in room descriptions rule" applies.]
[Rule "offer items to writing a paragraph about rule" applies.]
[Rule "use initial appearance in room descriptions rule" applies.]
[Rule "describe what's on scenery supporters in room descriptions rule" applies.]
[Rule "describe what's on mentioned supporters in room descriptions rule" applies.]
[Rule "don't mention player's supporter in room descriptions rule" applies.]
[Rule "don't mention scenery in room descriptions rule" applies.]
[Rule "don't mention undescribed items in room descriptions rule" applies.]
[Rule "set pronouns from items in room descriptions rule" applies.]
[Rule "offer items to writing a paragraph about rule" applies.]
[Rule "use initial appearance in room descriptions rule" applies.]
[Rule "describe what's on scenery supporters in room descriptions rule" applies.]
[Rule "describe what's on mentioned supporters in room descriptions rule" applies.]
[Rule "don't mention player's supporter in room descriptions rule" applies.]
[Rule "don't mention scenery in room descriptions rule" applies.]
[Rule "don't mention undescribed items in room descriptions rule" applies.]
[Rule "set pronouns from items in room descriptions rule" applies.]
[Rule "offer items to writing a paragraph about rule" applies.]
[Rule "use initial appearance in room descriptions rule" applies.]
[Rule "describe what's on scenery supporters in room descriptions rule" applies.]
[Rule "describe what's on mentioned supporters in room descriptions rule" applies.]
[Rule "initial appearance on supporters rule" applies.]
[Rule "don't mention player's supporter in room descriptions rule" applies.]
[Rule "don't mention scenery in room descriptions rule" applies.]
[Rule "don't mention undescribed items in room descriptions rule" applies.]
[Rule "set pronouns from items in room descriptions rule" applies.]
[Rule "offer items to writing a paragraph about rule" applies.]
[Rule "use initial appearance in room descriptions rule" applies.]
[Rule "describe what's on scenery supporters in room descriptions rule" applies.]
[Rule "describe what's on mentioned supporters in room descriptions rule" applies.]
[Rule "initial appearance on supporters rule" applies.]
[Rule "don't mention player's supporter in room descriptions rule" applies.]
[Rule "don't mention scenery in room descriptions rule" applies.]
[Rule "don't mention undescribed items in room descriptions rule" applies.]
[Rule "set pronouns from items in room descriptions rule" applies.]
[Rule "offer items to writing a paragraph about rule" applies.]
[Rule "use initial appearance in room descriptions rule" applies.]
[Rule "describe what's on scenery supporters in room descriptions rule" applies.]
[Rule "describe what's on mentioned supporters in room descriptions rule" applies.]
[Rule "don't mention player's supporter in room descriptions rule" applies.]
[Rule "don't mention scenery in room descriptions rule" applies.]
[Rule "don't mention undescribed items in room descriptions rule" applies.]
[Rule "set pronouns from items in room descriptions rule" applies.]
[Rule "offer items to writing a paragraph about rule" applies.]
[Rule "use initial appearance in room descriptions rule" applies.]
[Rule "describe what's on scenery supporters in room descriptions rule" applies.]
[Rule "describe what's on mentioned supporters in room descriptions rule" applies.]
[Rule "don't mention player's supporter in room descriptions rule" applies.]
[Rule "don't mention scenery in room descriptions rule" applies.]
[Rule "don't mention undescribed items in room descriptions rule" applies.]
[Rule "set pronouns from items in room descriptions rule" applies.]
[Rule "offer items to writing a paragraph about rule" applies.]
[Rule "use initial appearance in room descriptions rule" applies.]
[Rule "describe what's on scenery supporters in room descriptions rule" applies.]
[Rule "describe what's on mentioned supporters in room descriptions rule" applies.]
[Rule "don't mention player's supporter in room descriptions rule" applies.]
[Rule "don't mention scenery in room descriptions rule" applies.]
[Rule "don't mention undescribed items in room descriptions rule" applies.]
[Rule "set pronouns from items in room descriptions rule" applies.]
[Rule "offer items to writing a paragraph about rule" applies.]
[Rule "use initial appearance in room descriptions rule" applies.]
[Rule "describe what's on scenery supporters in room descriptions rule" applies.]
[Rule "describe what's on mentioned supporters in room descriptions rule" applies.]
[Rule "you-can-also-see rule" applies.]
[Rule "check new arrival rule" applies.]
[Rule "after stage rule" applies.]
[Rule "investigate player's awareness after action rule" applies.]
[Rule "report stage rule" applies.]
[Rule "Report looking when the curious-tool is locator" applies.]
With the curious tool in locator mode, you see a faint aura around the rotten beam.
[Rule "other people looking rule" applies.]
[Rule "last specific action-processing rule" applies.]
[Rule "last specific action-processing rule" applies.]
[Rule "A first turn sequence rule" applies.]
[Rule "every turn stage rule" applies.]
[Rule "Every turn when clonesubmerged is true and the player is not in dark-pool" applies.]
[Rule "Every turn when the player is not in grand-room" applies.]
[Rule "Every turn when the player is not in castle-region" applies.]
[Rule "Every turn when silver-fight is not happening" applies.]
[Rule "Every turn when the player is in garden-region" applies.]
[Rule "Every turn when the player is in garden-region" applies.]
[Rule "A time allotment rule for going" applies.]
[Rule "Every turn when the player is in garden-region" applies.]
[Rule "Every turn when the player is in cabin-interior" applies.]
[Rule "Every turn when cable-ladder is secretive" applies.]
[Rule "rod falling rule" applies.]
[Rule "Every turn when the train-door is closed" applies.]
[Rule "Every turn" applies.]
[Rule "Every turn" applies.]
[Rule "Every turn" applies.]
[Rule "clear personlists rule" applies.]
[Rule "clone copying rule" applies.]
[Rule "clone adjustment rule" applies.]
[Rule "clone trying to take rule" applies.]
[Rule "music duet rule" applies.]
[Rule "laser deactivation rule" applies.]
[Rule "finding cover rule" applies.]
[Rule "blaster taking rule" applies.]
[Rule "scope adjustment rule" applies.]
[Rule "clone reacting rule" applies.]
[Rule "A last turn sequence rule" applies.]
[Rule "notify score changes rule" applies.]
Have you checked your skein? Deleting a not-cleared-for-months skein recovered seconds for me. That was in 6M62, but I haven’t rechecked this behaviour it in 10.x.
The number of rules you quoted doesn’t look atypical or unusually large. So I’d say it’s particular mechanisms. If otis’s rule works it out for you, we might not have to guess for long.
Some ideas:
Definitions that are invoked that iterate through huge numbers of things every turn
A rule that iterates through all items every turn, or huge numbers of items (with tricky definitions?)
Any regex checks? They can slow things down. Using strategies to reduce their number or do things a simpler way can help.
Sometimes, using the helpful ‘now every BLAH is BLAHed’ parlance can be slower than writing a manual loop that does the same thing. Wouldn’t bother with this unless it’s happening all the time and you identify it as the culprit.
Do you use Eric Eve’s ‘old’ epistemology? Zarf replaced its core with way faster i6. That was a change that helped me a lot.
Btw, slowdown is more pronounced in Parchment/Quixe, so if you’re getting noticeable slowdown in an offline interpreter (other than Lectrote), I’d expect it to be worse in an online situation.
EDIT PS - In Lectrote, you can use its developer tools menu to turn on a display of how much time passes in ms between the user hitting return and the end of processing that turn. This is good for checking overall lag, or lag improvement. But because of the nature of Quixe, you have to perform some actions a few times to get the final results. There can be some processing overhead that only occurs the first time you do something, but if you do that thing again, you’ll get the time it takes to perform that action from then on, that basically won’t change.
I was able to shave the time from 3 seconds to 2 just by changing two ‘before’ rules. I noticed the ‘before stage rule’ was taking a long time, and that checks all the conditions on before rules. I had two rules from the Otranto example that said:
‘Before going when the player has something that is stuck to something anchored:’
I only need to use this in one part of the game, so I changed it to:
Before going when the player is in finale2-region:
if the player has something that is stuck to something anchored:
I’ll look at that one next! Searching, it seems to check if things involved in the action are visible. I was investigating slowdown, so I had my character purloin the largest group of items in the game (all the money, which in all of its denominations is a couple dozen items). So that might be unavoidable, but I could advise players to drop unneeded items. But I’ll check it!
Here’s a variant that does the elapsed time computation for you.
6M62:
'If only I had a computer to handle these details for me...` version
Section - Rules Timestamping
Include (-
Array prev_timestamp --> 3;
Array timestamp --> 3;
Array timestamp_diff --> 3;
Array timestamp_converted --> 8;
[ StoreLastTimestamp ;
prev_timestamp-->0 = timestamp-->0;
prev_timestamp-->1 = timestamp-->1;
prev_timestamp-->2 = timestamp-->2;
];
[ ComputeTimestampDiff n ;
n = timestamp-->2 - prev_timestamp-->2;
if (n < 0) {
! negative microseconds
(timestamp-->1)--; ! assume 21st century
timestamp_diff-->2 = 1000000-n;
} else {
! positive microseconds
timestamp_diff-->2 = n;
}
timestamp_diff-->1 = timestamp-->1 - prev_timestamp-->1; ! keep assuming 21st century
timestamp_diff-->0 = 0; ! keep assuming 21st century
];
[ PadToTens n ;
if (n < 10) print "0";
print n;
];
[ PadToHundredThousands n ;
if (n < 100000) print "0";
if (n < 10000) print "0";
if (n < 1000) print "0";
if (n < 100) print "0";
if (n < 10) print "0";
print n;
];
[ SayCurrentTimestamp load_only_flag;
glk_current_time(timestamp);
if (load_only_flag) rtrue;
glk_time_to_date_local(timestamp, timestamp_converted);
print (PadToTens) timestamp_converted-->4, ":", (PadToTens) timestamp_converted-->5, ":", (PadToTens) timestamp_converted-->6, ".", (PadToHundredThousands) timestamp_converted-->7;
];
[ SayDiffFromLastTimestamp i ;
StoreLastTimeStamp();
glk_current_time(timestamp);
ComputeTimestampDiff();
glk_time_to_date_local(timestamp_diff, timestamp_converted);
print (PadToTens) timestamp_converted-->5, ":", (PadToTens) timestamp_converted-->6, ".", (PadToHundredThousands) timestamp_converted-->7;
];
-).
To say current system timestamp:
(- SayCurrentTimestamp(); -).
To say elapsed system time:
(- SayDiffFromLastTimestamp(); -).
To mark initial system time:
(- SayCurrentTimestamp(true); StoreLastTimestamp(); -).
When play begins (this is the mark initial time rule):
mark initial system time.
Include (-
! ==== ==== ==== ==== ==== ==== ==== ==== ==== ====
! Rulebooks.i6t: Debugging
! ==== ==== ==== ==== ==== ==== ==== ==== ==== ====
[ DebugRulebooks subs parameter i;
spaces(2*process_rulebook_count);
print "[", (RulePrintingRule) subs;
if (parameter) print " / on O", parameter;
print "]^";
];
[ DB_Rule R N blocked;
if (R==0) return;
print "[Rule ~", (RulePrintingRule) R, "~ ";
#ifdef NUMBERED_RULES; print "(", N, ") "; #endif;
! BEGIN MODIFICATION
if (blocked == false) {
print "applies.]";
print " ("; SayDiffFromLastTimestamp(); ")";
}
! END MODIFICATION
print "does not apply (wrong ", (address) blocked, ").]^";
];
-) instead of "Debugging" in "Rulebooks.i6t".
For 10.1.2 (untested), you should only need to replace the second Include (- ... -). (at the end) with:
Include (-
[ DB_Rule R N blocked;
if (R==0) return;
print "[Rule ~", (RulePrintingRule) R, "~ ";
#ifdef NUMBERED_RULES; print "(", N, ") "; #endif;
! BEGIN MODIFICATION
if (blocked == false) {
print "applies.]";
print " ("; SayDiffFromLastTimestamp(); ")";
}
! END MODIFICATION
print "does not apply (wrong ", (address) blocked, ").]^";
];
-) replacing "DB_Rule".
Note that the first elapsed time value reported doesn’t measure the time elapsed since the player entered the command, it measures the time elapsed since the last timestamp was noted (when processing the previous command, or when play began for first shown value).
This was great! This helped me identify some regex slowdown. It also made me decide to completely rewrite the rope code to use item properties instead of relations, which has almost totally eliminated rope-based slowdown. I’m still debugging a few trouble spots, but this has been some immense help!
It can get pretty bad if you write code in dumb ways (like I was doing). It was basically checking hundreds of items to see if they were related to hundreds of items, multiple times per turn. It was enough to slow it down a lot when playing, unfortunately
I managed to slow down a tiny barely implemented toy game with one room and about 10 objects when I wrote a rule which effectively looped over every object in the game six nestings deep every turn. 10^6 = 1,000,000… it’s really easy to accidentally do that in Inform 7 if you’re not careful.
This is actually a general principle for speed optimization. Look out for nested loops; look out for loops over large numbers of things; and particularly look out for nested loops over large numbers of things. The “combinatorial explosion” is the most typical source of slow running times.
This looks really useful, as I have some performance issues in my game. I did manage to address some issues without it (I had some loops checking visibility and concealment of lots of objects that ran every turn), but this should help with any other issues that crop up.
I did make one small change to it:
[ SayDiffFromLastTimestamp i ;
StoreLastTimestamp();
glk_current_time(timestamp);
ComputeTimestampDiff();
glk_time_to_date_local(timestamp_diff, timestamp_converted);
! I added this line
if(timestamp_converted-->7 >= 1000*WORRYING_RULE_TIME || timestamp_converted-->6 > 0 || timestamp_converted-->5 > 0) style bold;
print (PadToTens) timestamp_converted-->5, ":", (PadToTens) timestamp_converted-->6, ".", (PadToHundredThousands) timestamp_converted-->7;
! and this line
style roman;
];
as well as a Constant WORRYING_RULE_TIME = 500; line above the array declarations.
That just makes times of more than 500ms be shown in bold. (The choice of 500 was somewhat random – I don’t really know what’s a good value for such a check.)
