Inform Library 6/12 and Inform 6.33.1 for Unix go beta

[Draconis (Daniel Stelzer)]

@auraes

It seems that something is wrong with: keep_silent = true;

Isn’t keep_silent meant to silence a single action?

[auraes]

@Draconis

Isn’t keep_silent meant to silence a single action?

I don’t think so? In DM4:

Actions marked KS run ‘‘silently’’ when the library’s variable keep_silent is set true. This means that if successful they print nothing: if unsuccessful,however, they print text as normal.

Most of the library’s group 2 actions are able to ‘‘run silently’’. This means that if the variable keep_silent is set to true, then the actions print nothing in the event of success. The group 2 actions which can’t run silently are exactly those ones whose successful operation does nothing but print: Wait, Inv, Look, Examine, Search.

The examples in the DM4 suggest that not.

[auraes]

@frotz

Auraes: Going back to your post about adding some calls to UnknownVerb(), here’s a commit with what you suggested.github.com/DavidGriffith/inform … 957ec5f06b

Sorry, you have to remove them! I can use instead LanguageIsVerb(). It seems made ​​for that, but before i can use and test it, see the next message…

[auraes]

Try this:

Include "parser.h"; Include "verblib.h";

Object room "Room" with description "Room test" has light;
Object -> apple  "apple"  with name 'apple'  has edible;
Object -> apple1 "apple1" with name 'apple1' has edible;
Object -> george "George" with name 'george' has animate male proper;

[ Initialise; location = room;];
Include "grammar.h";

Release 1 / Serial number 140823 / Inform v6.33 Library 6/12-beta1 S

Room
Room test

You can see an apple, an apple1 and George here.

>george,

>george,xyz

>george,eat xyz

>george, eat
What do you want to eat?

>xyz

>

All is Wrong.

[DavidG (David Griffith)]

@auraes

Try this:

Include "parser.h"; Include "verblib.h";

Object room "Room" with description "Room test" has light;
Object -> apple  "apple"  with name 'apple'  has edible;
Object -> apple1 "apple1" with name 'apple1' has edible;
Object -> george "George" with name 'george' has animate male proper;

[ Initialise; location = room;];
Include "grammar.h";

Release 1 / Serial number 140823 / Inform v6.33 Library 6/12-beta1 S

Room
Room test

You can see an apple, an apple1 and George here.

>george,

>george,xyz

>george,eat xyz

>george, eat
What do you want to eat?

>xyz

>

All is Wrong.

This is because there is no george.orders property. If you declared George like this:

Object -> george "George" 
        with name 'george', 
        orders [;
                "Hello!";
        ],
        has animate male proper;

George would then reply to anything you tell him with “Hello!”.

[DavidG (David Griffith)]

@auraes

@Draconis

Isn’t keep_silent meant to silence a single action?

I don’t think so? In DM4:

Actions marked KS run ‘‘silently’’ when the library’s variable keep_silent is set true. This means that if successful they print nothing: if unsuccessful,however, they print text as normal.

Most of the library’s group 2 actions are able to ‘‘run silently’’. This means that if the variable keep_silent is set to true, then the actions print nothing in the event of success. The group 2 actions which can’t run silently are exactly those ones whose successful operation does nothing but print: Wait, Inv, Look, Examine, Search.

The examples in the DM4 suggest that not.

I think you’re reading it wrong. The Library clears keep_silent when the silenced action has finished.

[Egon]

@Frotz

This is because there is no george.orders property.

Even so, shouldn’t the game say “There is no reply.”?

[DavidG (David Griffith)]

@Egon

@Frotz

This is because there is no george.orders property.

Even so, shouldn’t the game say “There is no reply.”?

You’re right. I’ll take care of that.

[DavidG (David Griffith)]

@auraes

In english.h: LanguageLM: Open: 4

Open: switch (n) {
		[...]
		4:  CSubjectVerb(actor,false,false,"open",0,"opens","opened"); print " ", (the) x1;
			Tense(", revealing ", " and revealed ");
			if (WriteListFrom(child(x1), ENGLISH_BIT+TERSE_BIT+CONCEAL_BIT) == 0) "nothing.";
			".";
		5:  CSubjectVerb(actor,false,false,"open",0,"opens","opened"); " ", (the) x1, ".";
    }

How target LanguageLM: Open: 4 to display “nothing.” I try and i can not display the message: “, revealing nothing.”
It seems as if Object container is empty, the message displayed is: L__M(##Open, 5, noun) else L__M(##Open, 4, noun). How WriteListFrom() can be equal to 0 in LanguageLM: Open: 4?
Not sure I’m clear!?

It looks like there was a longstanding problem with order of operations in OpenSub() and with WriteListFrom() not checking things properly.

[DavidG (David Griffith)]

Okay, I think that’s it for the latest batch of bugs, Auraes. What’s next?

[auraes]

@frotz

I think you’re reading it wrong. The Library clears keep_silent when the silenced action has finished.

I think not, in library 6/11:

Release 1 / Serial number 140824 / Inform v6.33 Library 6/11 S

room
Room

You can see a box (which is closed) and a box1 (which is closed) here.

>open box

>open box1

>close box

>close box1

> 

Otherwise, what is the interest of keep_silent? Look at the examples in the dm4. Before , they always save the value of keep_silent.ks = keep_silent; keep_silent = true; <Close self>; keep_silent = ks;

[auraes]

@auraes

In english.h:
LanguageLM CommandsRead:3 “[Command replay failed. Command recording is on.]”;
There are two space characters between: failed & Command.

LanguageLM: Examine: 1 “Darkness, noun. An absence of light to see by.”; => two spaces between noun & An?
LanguageLM: Enter: 2 " can " => Tense(" can ", " could “)?
LanguageLM: Go: 6 “nowhere.” => " nowhere.”?
LanguageLM: Insert: 10 SupportObj(x2,“on”,“in”), (the) x2, “.”; => SupportObj(x2,"on ",“in “)
LanguageLM: Lock: 1 (theActor) actor, " can lock.”; => Tense(” can ", " could ")?

[auraes]

@auraes

If an Object has container and open and there is inside an Object with concealed or scenery, maybe he should display: You can see a box (which is open) here." instead of “You can see a box here.”

@frotz

It looks like there was a longstanding problem with order of operations in OpenSub() and with WriteListFrom() not checking things properly.

Release 1 / Serial number 140824 / Inform v6.33 Library 6/12-beta1 S

room
Room

You can see a box (which is empty), a box1 (which is closed), a box2 (which is
empty) and a box3 (in which is an apple) here.

Sorry, but the Object box is open but not empty. Object box isn’t equal to Object box2. There’s an Object ‘concealed’ and un Object ‘scenery’ in it:

In DM4:
Concealed:
‘‘Concealed from view but present.’’ The player object has this; an
object which was the player until ChangePlayer happened loses this
property; a concealed door can’t be entered; does not appear in room
descriptions.
Scenery:
Not listed by the library in room descriptions; ‘‘not portable’’ to be
taken; ‘‘you are unable to’’ pull, push, or turn it.

OK… keep_silent = true: i’ll shut up.

[DavidG (David Griffith)]

@auraes

@frotz

I think you’re reading it wrong. The Library clears keep_silent when the silenced action has finished.

I think not, in library 6/11:

Release 1 / Serial number 140824 / Inform v6.33 Library 6/11 S

room
Room

You can see a box (which is closed) and a box1 (which is closed) here.

open box

open box1

close box

close box1

Otherwise, what is the interest of keep_silent? Look at the examples in the dm4. Before , they always save the value of keep_silent.ks = keep_silent; keep_silent = true; <Close self>; keep_silent = ks;

Okay. Bug filed.

[DavidG (David Griffith)]

@auraes

@auraes

In english.h:
LanguageLM CommandsRead:3 “[Command replay failed. Command recording is on.]”;
There are two space characters between: failed & Command.

LanguageLM: Examine: 1 “Darkness, noun. An absence of light to see by.”; => two spaces between noun & An?
LanguageLM: Enter: 2 " can " => Tense(" can ", " could “)?
LanguageLM: Go: 6 “nowhere.” => " nowhere.”?
LanguageLM: Insert: 10 SupportObj(x2,“on”,“in”), (the) x2, “.”; => SupportObj(x2,"on ","in ")

I was always taught when typing to put two spaces after a period, question mark, or exclaimation mark. Whether one does so or not these days is subject to much debate. There’s a compile-time option to contract these to one space after periods only or all three of these marks. I can safely leave these as-is.

Tense() call added.

Leading space added.

Trailing space added. It appears that the Library does not actually call L__M(##Insert, 10). That one is clearly intended for complaining that the bowling ball is too large to put into the pill bottle (for instance). Can you think of a way to cleanly and generally implement this or are we better off removing that response?

[DavidG (David Griffith)]

@auraes

@auraes

If an Object has container and open and there is inside an Object with concealed or scenery, maybe he should display: You can see a box (which is open) here." instead of “You can see a box here.”

@frotz

It looks like there was a longstanding problem with order of operations in OpenSub() and with WriteListFrom() not checking things properly.

Release 1 / Serial number 140824 / Inform v6.33 Library 6/12-beta1 S

room
Room

You can see a box (which is empty), a box1 (which is closed), a box2 (which is
empty) and a box3 (in which is an apple) here.

Sorry, but the Object box is open but not empty. Object box isn’t equal to Object box2. There’s an Object ‘concealed’ and un Object ‘scenery’ in it:

In DM4:
Concealed:
‘‘Concealed from view but present.’’ The player object has this; an
object which was the player until ChangePlayer happened loses this
property; a concealed door can’t be entered; does not appear in room
descriptions.
Scenery:
Not listed by the library in room descriptions; ‘‘not portable’’ to be
taken; ‘‘you are unable to’’ pull, push, or turn it.

OK… keep_silent = true: i’ll shut up.

I thought that if a container contains a concealed or scenery object, that container should be reported as “empty” because such objects do not appear in room descriptions. If you have a box that’s just reported as open and another reported as empty, the player is given a clue that probably should not be given. Or am I misunderstanding this?

[auraes]

LanguageLM: Enter: 2 " can " => Tense(" can “, " could “)? You correct but you forgot space after can & could.
LanguageLM: Lock: 1 (theActor) actor, " can lock.”; => Tense(” can ", " could ")?

@frotz

Can you think of a way to cleanly and generally implement this or are we better off removing that response?

I don’t know. It’s not in library 6/11. My English is too bad to argue about this kind of question.

[mulehollandaise]

Just a quick message to tell you to keep up the good work, guys! Thanks for this deep testing and for the quick bugfixes, can’t wait to use the new version!

[DavidG (David Griffith)]

@auraes

LanguageLM: Enter: 2 " can " => Tense(" can “, " could “)? You correct but you forgot space after can & could.
LanguageLM: Lock: 1 (theActor) actor, " can lock.”; => Tense(” can ", " could ")?

@frotz

Can you think of a way to cleanly and generally implement this or are we better off removing that response?

I don’t know. It’s not in library 6/11. My English is too bad to argue about this kind of question.

Fixed these two and removed LanguageLM: Insert: 10.

[DavidG (David Griffith)]

I traced the keep_silent business to github.com/DavidGriffith/inform … 7cb7db9049 (the old CVS repo). Look for this line in parserm.h:

keep_silent = 0;    ! should be zero anyway, but just in case...

That was made by Roger Firth on September 4, 2004. I don’t know what was going through Roger’s head when he did that. Would someone please enlighten me as to what was going on there? What was he attempting to head off as alluded to by that “just in case” comment?

Auraes, please comment out that line from the latest version and tell me what you think?